[Webkit-unassigned] [Bug 171907] Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171907

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org
 Attachment #309574|review?                     |review+
              Flags|                            |

--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 309574
  --> https://bugs.webkit.org/attachment.cgi?id=309574
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=309574&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/InspectorFrontendHostStub.js:124
> +            const textarea = document.createElement("textarea");

Nit: We would typically use `let` instead of const, but it doesn't really matter.

Our style for when we use `const` tends to be when the value is the equivalent of a compile time constant. So `const timeToWait = 1000;" but not `const timeToWait = x * y;`. Maybe we should change that style though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170510/97f2fe7d/attachment-0001.html>