[Webkit-unassigned] [Bug 171918] [GTK] Bump GTK+ and its dependencies in jhbuild

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171918

--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Alberto Lopez Perez from comment #3)
> Comment on attachment 309589 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309589&action=review
> 
> > Tools/gtk/jhbuild.modules:606
> > +      <dep package="harfbuzz"/>
> > +      <if condition-unset="macos">
> > +	<dep package="harfbuzz"/>
> > +	<dep package="fontconfig"/>
> > +      </if>
> 
> I just noticed this...
> 
> I think there is some trouble on this block of dependencies.
> 
>  <dependencies>
>       <dep package="glib"/>
>       <dep package="cairo"/>
>       <dep package="harfbuzz"/>
>       <if condition-unset="macos">
> 	<dep package="harfbuzz"/>
> 	<dep package="fontconfig"/>
>       </if>
>     </dependencies>
> 
> why harfbuzz is twice for condition != macos.

I forgot to remove the previous line, I'll do it in a follow up. Good catch!.

> And why fontconfig was before unconditionally and now is only for != macos

Because in macos CoreFoo libraries are used instead. This is what the original jhbuild has:

<if condition-unset="quartz">
        <dep package="harfbuzz"/>
        <dep package="fontconfig"/>
</if>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170510/6d0847a6/attachment-0001.html>