[Webkit-unassigned] [Bug 171720] [preload] Add media and type attribute support.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 9 00:09:22 PDT 2017


--- Comment #12 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to youenn fablet from comment #11)
> (In reply to Yoav Weiss from comment #2)
> > This is adding media and type support for the Link preload feature.
> > 
> > A few more tests are needed around unsupported types other than images and
> > around Link header support for the media attribute (especially with various
> > <meta viewport>s), but I wanted to kick off the review to get an opinion on
> > the general approach. I'm hoping to add the required tests shortly.

I'm failing to test <meta viewport> with http tests :/
I tried `<!-- webkit-test-runner [ useFlexibleViewport=true ] -->` in a php file, but viewport remains 800px despite a `<meta name="viewport" content="width=160">` directive.

Any advice on how that can be accomplished? Otherwise, I can try different expected results for ios and other platforms, but it's uglier...

> General approach seems fine.
> I am not sure about video preloading since the backend may not reuse the
> memory cache.
> Jer, Eric, any opinion?

That's a valid concern, but related to preloading videos in general, right? (so not specific to this patch)

>From what I've seen videos weren't downloaded twice, but fragment downloads make it hard to verify through tests.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170509/6283710d/attachment.html>

More information about the webkit-unassigned mailing list