[Webkit-unassigned] [Bug 171799] WebAssembly: don't just emit extended offset adds for patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171799

JF Bastien <jfbastien at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|webkit-unassigned at lists.web |jfbastien at apple.com
                   |kit.org                     |
 Attachment #309346|                            |review?, commit-queue?
              Flags|                            |

--- Comment #1 from JF Bastien <jfbastien at apple.com> ---
Created attachment 309346

  --> https://bugs.webkit.org/attachment.cgi?id=309346&action=review

patch

pizlo had said:

(In reply to Filip Pizlo from comment #30)
> Comment on attachment 309022 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=309022&action=review
> 
> > Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp:80
> > +                        if (isPatch && inst.admitsExtendedOffsetAddr(arg)) {
> 
> I would drop the isPatch check

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170508/e2c7cf8d/attachment-0001.html>