[Webkit-unassigned] [Bug 162704] [Coordinated Graphics] Debug Visuals don't hide

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 7 16:06:23 PDT 2017


--- Comment #3 from Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa at sony.com> ---
(In reply to Gwang Yoon Hwang from comment #2)
> Comment on attachment 290144 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=290144&action=review
> > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:478
> > +    m_layerState.debugVisuals.showDebugBorders = show;
> Nice finding! But I think it is enough to remove this line:
> m_layerState.showDebugBorders = true;
> Because CoordinatedGraphicsLayer::syncLayerState will set the proper value
> to the m_layerState.showDebugBorder

Thanks for reviewing. Yes, actually the minimum fix is like:

-    m_layerState.showDebugBorders = true;
+    m_layerState.debugBorderColorChanged = true; // This forces the debug visuals update

Without setting the debugBorderColorChanged flag the debug visuals are not updated because the code to change the visuals refers to only the "debugBorderColorChanged" and "debugBorderWidthChanged" flags

   if (layerState.debugBorderColorChanged || layerState.debugBorderWidthChanged)
                layer->setDebugVisuals(layerState.showDebugBorders, layerState.debugBorderColor, layerState.debugBorderWidth, layerState.showRepaintCounter);

> BTW, do you have any other reason to make a new structure for debug visual?
> Even in current implementation, we sent these changes to the compositing
> thread with a single commit.

So, at least, with the current implementation, we need to add two update flags for the "showDebugBorders" and "showRepaintCounter" state. But instead, I made a new structure for debug visuals and an update flag for it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170507/bfaec1b1/attachment.html>

More information about the webkit-unassigned mailing list