[Webkit-unassigned] [Bug 171492] REGRESSION(r215188?): Test platform/gtk/fast/forms/menulist-typeahead-find.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 7 05:41:38 PDT 2017


--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
This started failing after the following set of fixes which I made for
fixing the following popup-related bugs:

 * Bug #145866: [GTK] Attach popup menu to web view widget
   Landed: http://trac.webkit.org/changeset/215225

 * Bug #170553: [GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
   Landed: http://trac.webkit.org/changeset/215190

 * Bug #170680: [GTK] Opening a popup menu does not pre-select the active item
   Landed: http://trac.webkit.org/changeset/215188

Reverting r215225 makes the typeahead find elements again, but the
items being found sometimes are not exactly the ones from the test
expectation. The diff is:

  --- /home/aperez/devel/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/fast/forms/menulist-typeahead-find-expected.txt
  +++ /home/aperez/devel/WebKit/WebKitBuild/Release/layout-test-results/platform/gtk/fast/forms/menulist-typeahead-find-actual.txt
  @@ -3,8 +3,8 @@
   Cannot run interactively.
   Expected Apple: was Apple
   Expected Carrot: was Carrot
  -Expected Cauliflower: was Cauliflower
  -Expected Corn: was Corn
  +Expected Cauliflower: was Carrot
  +Expected Corn: was Cauliflower
   Expected Carrot: was Carrot
   Expected Apple: was Apple
   Expected Cauliflower: was Cauliflower

The bit that is not working is this part of the test:

   // This tests that iterating via pressing the same key works.
   testTypeAheadFind(['c', 'c'], "Cauliflower");
   testTypeAheadFind(['c', 'c', 'c'], "Corn");

Checking the code of the “testTypeAheadFind()” function, I see that it
does not attempt to reset the status of the form element to an initial
know state, so each call to this function will behave differently
depending on the state leftover from the previous call.

After fixing bug #170680 now the code is pre-selecting the active item
on popup (simulated here by sending a pair of button-down/button-up
events): that was not happening before and the typeahead was searching
always from the beginning of the list. IMHO the correct thing to do in
this regard is to always reset the form element to a known state at the
beginning of “testTypeAheadFind()”.

I still don't know why attaching the popup menu to the web widget makes
the test function always choose the “Apple” item, though. That needs more

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170507/8a5ed999/attachment.html>

More information about the webkit-unassigned mailing list