[Webkit-unassigned] [Bug 170833] Fix 32bit Windows build by giving correct parameters to MASM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170833

--- Comment #9 from Don Olmstead <don.olmstead at am.sony.com> ---
(In reply to Bill Ming from comment #8)
> (In reply to Don Olmstead from comment #7)
> > Okay so I looked into things a bit more since I'm also hitting this when
> > using clang-cl for building WinCairo.
> > 
> > It really looks like a larger issue with how WebKit is using CMake that in
> > this case is hitting an issue with ml failing when you give it too many
> > unsupported parameters.
> > 
> > I looked at the ninja.build file and saw the FLAGS being sent to it included
> > stuff like the block of /wd's in Source/cmake/OptionsWin.cmake.
> > 
> > If it sees an add_definitions and its a compile option like /wd's then those
> > end up on the flags. If you use add_compile_options it also ends up on the
> > flags.
> > 
> > However you can make something like add_compile_options conditional. Doing
> > the following makes it so those warnings don't end up on the FLAGS in the
> > call to the assembler.
> > 
> >     set(VS_WARNINGS
> >         /wd4018 /wd4068 /wd4099 /wd4100 /wd4127 /wd4138 /wd4146 /wd4180
> > /wd4189
> >         /wd4201 /wd4206 /wd4244 /wd4251 /wd4267 /wd4275 /wd4288 /wd4291
> > /wd4305
> >         /wd4309 /wd4344 /wd4355 /wd4389 /wd4396 /wd4456 /wd4457 /wd4458
> > /wd4459
> >         /wd4481 /wd4503 /wd4505 /wd4510 /wd4512 /wd4530 /wd4610 /wd4611
> > /wd4646
> >         /wd4702 /wd4706 /wd4722 /wd4800 /wd4819 /wd4951 /wd4952 /wd4996
> > /wd6011
> >         /wd6031 /wd6211 /wd6246 /wd6255 /wd6387
> >     )
> > 
> >     add_compile_options(
> >         "$<$<COMPILE_LANGUAGE:C>:${VS_WARNINGS}>"
> >         "$<$<COMPILE_LANGUAGE:CXX>:${VS_WARNINGS}>"
> >     )
> > 
> > Perhaps this is a better way to approach the problem?
> 
> Yeah, /wd is something break the build. but maybe we should not pass other
> cl flags to the ml.
> 
> MASM : warning A4018:invalid command-line option : /GS
> MASM : warning A4018:invalid command-line option : /EHa-
> MASM : warning A4018:invalid command-line option : /EHc-
> MASM : warning A4018:invalid command-line option : /EHs-
> MASM : warning A4018:invalid command-line option : /fp:except-
> MASM : warning A4018:invalid command-line option : /analyze-
> MASM : warning A4018:invalid command-line option : /bigobj
> MASM : warning A4018:invalid command-line option : /openmp-
> MASM : warning A4018:invalid command-line option : /GF-
> MASM : warning A4018:invalid command-line option : /Oy-

I agree its just quite a bit more surgery to get right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170505/2756f350/attachment.html>