[Webkit-unassigned] [Bug 171632] [Tools] Add support for clang-tidy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171632

--- Comment #7 from Don Olmstead <don.olmstead at am.sony.com> ---
(In reply to Jonathan Bedard from comment #6)
> I'm sorry, I misread your first command Don.  You are using Clang's WebKit
> style.
> 
> I looked into using clang's WebKit style a few months ago.  I'm not sure
> where clang is getting their specifications for WebKit style from, it was a
> surprise to our team that this was an option.  While clang's format options
> are close to what we use, they fall short with some spacing problems, which
> actually requires modification of clang's source to correction.  If I
> remember correctly, the patch you posted here actually has that issue:
> 
> constexpr constexpr_optional_base() __NOEXCEPT :, storage_(trivial_init){};
> 
> should be
> 
> constexpr constexpr_optional_base() __NOEXCEPT :, storage_(trivial_init) {};
> 
> The style checker in WebKit (./Tools/Scripts/check-webkit-style) probably
> flags this, no?

Yep it does flag that particular instance. Adding the diff and style checker results momentarily.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170504/e7913111/attachment.html>