[Webkit-unassigned] [Bug 171632] [Tools] Add support for clang-tidy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171632

--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
(In reply to Alexey Proskuryakov from comment #3)
> Last I checked, clang's idea of WebKit style was quite wrong. Has that
> changed?

Not since I've last checked.  Although, I wouldn't call it 'quite wrong,' if memory serves, there were a few minor discrepancies with spacing between if statements, I believe.

But Looking through what Don is suggesting here, this isn't Clang's WebKit style.  In fact, looking at the changes made to the Optional class, it's looking to me like that file didn't adhere to our style guidelines in the first place.

Don, if you run the webkit style checker on these changes (./Tools/Scripts/check-webkit-style), what does it say?  I could see it complaining about some of the spacing changes in Source/WTF/wtf/Optional.h.  Remember that the WebKit style checker only checks code which has changed, so it's a pretty common occurrence for code in the tree to be in violation of the style guidelines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170504/11ea441c/attachment.html>