[Webkit-unassigned] [Bug 171595] [GTK] Bump GStreamer version to 1.10.4 in jhbuild

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171595

--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Alberto Lopez Perez from comment #13)
> Comment on attachment 308892 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=308892&action=review
> 
> I have checked the patches, I comment below inline which ones should be kept
> or removed

Wow, thanks for doing the boring work!

> > Tools/gtk/jhbuild.modules:-374
> > -      <patch file="gstreamer-0001-protection-added-function-to-filter-system-ids.patch" strip="1"/>
> 
> I don't see it merged anywhere neither any bug related to it. I guess its
> still a WIP.
> Keep this patch.

I still don't understand why we keep patches for our dependencies that are not tracked upstream and don't fix any test.

> > Tools/gtk/jhbuild.modules:-406
> > -      <patch file="gst-plugins-good-use-the-tfdt-decode-time.patch" strip="1"/>
> 
> Already merged in 1.10.4 :
> https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=a2adb7e30
> Remove it
> 
> > Tools/gtk/jhbuild.modules:-407
> > -      <patch file="gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch" strip="1"/>
> 
> Already merged in 1.10.4 :
> https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=707c69cb7
> Remove it
> 
> > Tools/gtk/jhbuild.modules:-408
> > -      <patch file="gst-plugins-good-0001-rtpbin-pipeline-gets-an-EOS-when-any-rtpsources-byes.patch" strip="1"/>
> 
> Merged in 1.10.4 :
> https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=7ec1ba2bf
> Note: This was reverted on master, but not on 1.10.4 .. this means we may
> need to recover it on the future if we update beyond 1.10.4 and the patch
> doesn't gets merged again upstream.
> For the moment (update to 1.10.4) we should just simply remove it as it is
> merged on 1.10.4
> Remove it
> 
> > Tools/gtk/jhbuild.modules:-409
> > -      <patch file="gst-plugins-good-0002-rtpbin-avoid-generating-errors-when-rtcp-messages-ar.patch" strip="1"/>
> 
> Already merged in 1.10.4 :
> https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=7708a1793
> Remove it
> 
> > Tools/gtk/jhbuild.modules:-410
> > -      <patch file="gst-plugins-good-0003-rtpbin-receive-bundle-support.patch" strip="1"/>
> 
> This was merged on
> https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/
> ?id=dcd3ce9751cdef0b5ab1fa118355f92bdfe82cb3 (>= 1.11.1)
> So, we need to keep this patch because its not on 1.10.4
> Keep this patch.
> 
> > Tools/gtk/jhbuild.modules:-411
> > -      <patch file="gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch" strip="1"/>
> 
> I don't see it merged anywhere neither any bug related to it. I guess its
> still a WIP.
> Keep this patch.
> 
> > Tools/gtk/jhbuild.modules:-427
> > -      <patch file="gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch" strip="1"/>
> 
> Already merged in 1.10.4 :
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=e93893316
> Remove it
> 
> > Tools/gtk/jhbuild.modules:-428
> > -      <patch file="gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch" strip="1"/>
> 
> Already merged in 1.10.4 :
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=b810d09fd
> Remove it

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170504/3ad5a6a9/attachment.html>