[Webkit-unassigned] [Bug 22614] Need to add Win32 implementation of ThreadSpecific.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22614

Nico Weber <thakis at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thakis at chromium.org

--- Comment #24 from Nico Weber <thakis at chromium.org> ---
Comment on attachment 26502
  --> https://bugs.webkit.org/attachment.cgi?id=26502
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=26502&action=review

> JavaScriptCore/wtf/ThreadSpecific.h:152
> +    // Does not invoke destructor functions. They will be called from ThreadSpecificThreadExit when the thread is detached.

You probably don't care since it's now 9 years after you wrote this code, but this dtor is never called. ThreadSpecificThreadExit calls the destructor function, but that's set to &ThreadSpecific<T>::destroy, and that only calls data->value->~T(), not data->owner->~ThreadSpecific(). From what I can tell, this is still the case in webkit trunk today.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170503/f115899b/attachment.html>