[Webkit-unassigned] [Bug 171604] New: Cleanup: Remove out-of-date comment and null check from DocumentLoader::detachFromFrame()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171604

            Bug ID: 171604
           Summary: Cleanup: Remove out-of-date comment and null check
                    from DocumentLoader::detachFromFrame()
           Product: WebKit
           Version: WebKit Local Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: dbates at webkit.org
                CC: beidson at apple.com

We no longer want to passively allow DocumentLoader::detachFromFrame() to be called twice as it never makes sense to for it to be called twice and indicates a bug that we want to fix. A release assert in DocumentLoader::cancelPolicyCheckIfNeeded() (added in r187558) called by DocumentLoader::detachFromFrame() enforces this invariant. We should remove the unnecessary null check of DocumentLoader::m_frameand the comment that explains this null check from DocumentLoader::detachFromFrame().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170503/42302168/attachment-0001.html>