[Webkit-unassigned] [Bug 162704] [Coordinated Graphics] Debug Visuals don't hide

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 3 09:04:45 PDT 2017


Gwang Yoon Hwang <yoon at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |yoon at igalia.com

--- Comment #2 from Gwang Yoon Hwang <yoon at igalia.com> ---
Comment on attachment 290144
  --> https://bugs.webkit.org/attachment.cgi?id=290144

View in context: https://bugs.webkit.org/attachment.cgi?id=290144&action=review

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:478
> +    m_layerState.debugVisuals.showDebugBorders = show;

Nice finding! But I think it is enough to remove this line:
m_layerState.showDebugBorders = true;

Because CoordinatedGraphicsLayer::syncLayerState will set the proper value to the m_layerState.showDebugBorder

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:490
> +    m_layerState.debugVisuals.showRepaintCounter = show;

Same here.

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:79
> +    float debugBorderWidth;

Nowadays, we initialize members like this:
float debugBorderWidth { 0 };

> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:87
> +};

BTW, do you have any other reason to make a new structure for debug visual?
Even in current implementation, we sent these changes to the compositing thread with a single commit.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170503/934da651/attachment.html>

More information about the webkit-unassigned mailing list