[Webkit-unassigned] [Bug 170747] Link preload HTMLPreloadScanner support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170747

--- Comment #6 from Yoav Weiss <yoav at yoav.ws> ---
(In reply to youenn fablet from comment #4)
> Comment on attachment 306857 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=306857&action=review
> 
> > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:149
> > +        std::optional<CachedResource::Type> type = resourceType();
> 
> Use auto maybe?

done
> 
> > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:7
> > +    shouldBeTrue("internals.isPreloaded('../resources/dummy.js');");
> 
> Can you exit early if window.intrrnals is undefined?

done
> 
> > LayoutTests/http/tests/preload/preloadscanner_download_resources.html:8
> > +    shouldBeTrue("internals.isPreloaded('../resources/dummy.css');");
> 
> Exit with a proper message..,

Not sure what you mean, as `shouldBeTrue` has no parameter for a more meaningful message. Can you elaborate?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170503/e22b80a7/attachment.html>