[Webkit-unassigned] [Bug 171510] check-webkit-style exits with an error while parsing Source/WebKit2/Scripts/webkit/ directory: KeyError: 'st'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171510

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dean_johnson at apple.com

--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to David Kilzer (:ddkilzer) from comment #4)
> As it turns out, fixing the warnings in messages_unittest.py (and parser.py)
> also fixes this error.
> 
> I think the source of the bug was a bad import statement:
> 
> -import parser
> +from webkit import parser
> 
> The next step is to figure out how to make messages_unittest.py and
> messages.py both work with the same import statement (and still make
> check-webkit-style happy).
> 
> Note that running messages_unittest.py now fails as the expected output
> hasn't been updated with other changes (probably because
> messages_unittest.py isn't run regularly by anyone or any bot).

Dan basically covered this in the comments above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170503/f6dd4ace/attachment-0001.html>