[Webkit-unassigned] [Bug 170747] Link preload HTMLPreloadScanner support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170747

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306857|review?                     |review+
              Flags|                            |

--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 306857
  --> https://bugs.webkit.org/attachment.cgi?id=306857
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306857&action=review

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:149
> +        std::optional<CachedResource::Type> type = resourceType();

Use auto maybe?

> LayoutTests/http/tests/preload/preloadscanner_download_resources.html:7
> +    shouldBeTrue("internals.isPreloaded('../resources/dummy.js');");

Can you exit early if window.intrrnals is undefined?

> LayoutTests/http/tests/preload/preloadscanner_download_resources.html:8
> +    shouldBeTrue("internals.isPreloaded('../resources/dummy.css');");

Exit with a proper message..,

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170502/356e83ce/attachment.html>