[Webkit-unassigned] [Bug 143678] javascript window.open window size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143678

--- Comment #11 from Chris Dumez <cdumez at apple.com> ---
(In reply to Chris Dumez from comment #10)
> (In reply to Tim Horton from comment #9)
> > (In reply to Tim Horton from comment #8)
> > > (In reply to Chris Dumez from comment #7)
> > > > Page::setTopContentInset() gets called *after* we set the new Window size
> > > > unfortunately.
> > > 
> > > Where is the size set? You might be able to reorder it, because TCI is sent
> > > in WebProcessCreationParameters, so it's not like we don't have it.
> > 
> > WebPageCreationParameters, whatever.
> 
> The logic for setting the new window size is in:
> RefPtr<Frame> createWindow(Frame& openerFrame, Frame& lookupFrame, const
> FrameLoadRequest& request, const WindowFeatures& features, bool& created)
> inside FrameLoader.cpp.
> 
> We first call chrome().createWindow() to create the Window.
> Then we compute the height we want.
> Finally we call chrome().setWindowRect().

And to make things a bit more complicated, between the window creation and setting the window size, there is a call to chrome().setToolbarsVisible(), which I believe would impact the topContentInset.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170502/9f3b0943/attachment.html>