[Webkit-unassigned] [Bug 171363] Web Inspector: ASSERT(!m_startedComposite) fails when recording on non-Cocoa Timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171363

Matt Baker <mattbaker at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mattbaker at apple.com
 Attachment #308327|review?                     |review+, commit-queue+
              Flags|                            |

--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 308327
  --> https://bugs.webkit.org/attachment.cgi?id=308327
Patch

r=me.

I don't have an easy way to test this, but it seems clear that the second time willComposite is called (and every time after) it will assert, since didComposite is never called. Ross's patch matches the guards around the creation of the run loop observation points and looks correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170501/a2eec322/attachment-0001.html>