[Webkit-unassigned] [Bug 171510] check-webkit-style exits with an error while parsing Source/WebKit2/Scripts/webkit/ directory: KeyError: 'st'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171510

--- Comment #1 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Deleting parser.py "fixes" the error:

$ rm -f Source/WebKit2/Scripts/webkit/parser.py
$ ./Tools/Scripts/check-webkit-style Source/WebKit2/Scripts/webkit/
ERROR: Source/WebKit2/Scripts/webkit/LegacyMessageReceiver-expected.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/Scripts/webkit/LegacyMessageReceiver-expected.cpp:77:  _result is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/Scripts/webkit/LegacyMessageReceiver-expected.cpp:96:  _result is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/Scripts/webkit/LegacyMessages-expected.h:25:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebKit2/Scripts/webkit/LegacyMessages-expected.h:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Scripts/webkit/MessageReceiver-expected.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/Scripts/webkit/MessageReceiver-expected.cpp:77:  _result is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/Scripts/webkit/MessageReceiver-expected.cpp:96:  _result is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/Scripts/webkit/MessageReceiverSuperclass-expected.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/Scripts/webkit/Messages-expected.h:25:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebKit2/Scripts/webkit/Messages-expected.h:45:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Scripts/webkit/MessagesSuperclass-expected.h:25:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebKit2/Scripts/webkit/MessagesSuperclass-expected.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:160:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:213:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:302:  missing whitespace after ':'  [pep8/E231] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:315:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:318:  missing whitespace after ':'  [pep8/E231] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:346:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:414:  expected 2 blank lines, found 1  [pep8/E302] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages.py:465:  too many blank lines (2)  [pep8/E303] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:52:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:246:  whitespace before ':'  [pep8/E203] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:311:  too many blank lines (3)  [pep8/E303] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:262:  [MessagesTest.setUp] Module 'parser' has no 'parse' member  [pylint/E1101] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:263:  [MessagesTest.setUp] Module 'parser' has no 'parse' member  [pylint/E1101] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:264:  [MessagesTest.setUp] Module 'parser' has no 'parse' member  [pylint/E1101] [5]
ERROR: Source/WebKit2/Scripts/webkit/model.py:41:  expected 2 blank lines, found 1  [pep8/E302] [5]
Total errors found: 28 in 17 files

However, running check-webkit-style on just parser.py works fine:

$ git checkout HEAD Source/WebKit2/Scripts/webkit/parser.py
$ ./Tools/Scripts/check-webkit-style Source/WebKit2/Scripts/webkit/parser.py
ERROR: Source/WebKit2/Scripts/webkit/parser.py:124:  expected 2 blank lines, found 1  [pep8/E302] [5]
Total errors found: 1 in 1 files

Okay, I've narrowed it down to two just files:

$ ./Tools/Scripts/check-webkit-style Source/WebKit2/Scripts/webkit/messages_unittest.py Source/WebKit2/Scripts/webkit/parser.py
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:52:  trailing whitespace  [pep8/W291] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:246:  whitespace before ':'  [pep8/E203] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:311:  too many blank lines (3)  [pep8/E303] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:262:  [MessagesTest.setUp] Module 'parser' has no 'parse' member  [pylint/E1101] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:263:  [MessagesTest.setUp] Module 'parser' has no 'parse' member  [pylint/E1101] [5]
ERROR: Source/WebKit2/Scripts/webkit/messages_unittest.py:264:  [MessagesTest.setUp] Module 'parser' has no 'parse' member  [pylint/E1101] [5]
ERROR: Source/WebKit2/Scripts/webkit/parser.py:124:  expected 2 blank lines, found 1  [pep8/E302] [5]
Traceback (most recent call last):
  File "./Tools/Scripts/check-webkit-style", line 48, in <module>
    sys.exit(CheckWebKitStyle().main())
  File "./Tools/Scripts/webkitpy/style/main.py", line 149, in main
    file_reader.process_paths(paths)
  File "./Tools/Scripts/webkitpy/style/filereader.py", line 136, in process_paths
    self.process_file(path)
  File "./Tools/Scripts/webkitpy/style/filereader.py", line 124, in process_file
    self._processor.process(lines, file_path, **kwargs)
  File "./Tools/Scripts/webkitpy/style/checker.py", line 896, in process
    checker.check(lines)
  File "./Tools/Scripts/webkitpy/style/checkers/python.py", line 43, in check
    self._check_pylint(lines)
  File "./Tools/Scripts/webkitpy/style/checkers/python.py", line 71, in _check_pylint
    output = pylinter.run(['-E', self._file_path])
  File "./Tools/Scripts/webkitpy/style/checkers/python.py", line 106, in run
    lint.Run(['--rcfile', self._pylintrc] + argv, reporter=ParseableTextReporter(output=output), exit=False)
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 879, in __init__
    linter.check(args)
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 502, in check
    self.check_astng_module(astng, walker, rawcheckers)
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/lint.py", line 574, in check_astng_module
    walker.walk(astng)
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 528, in walk
    self.walk(child)
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/utils.py", line 525, in walk
    cb(astng)
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/base.py", line 157, in visit_class
    self._check_redefinition('class', node)
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/pylint/checkers/base.py", line 221, in _check_redefinition
    defined_self = node.parent.frame()[node.name]
  File "./Tools/Scripts/webkitpy/thirdparty/autoinstalled/logilab/astng/scoped_nodes.py", line 178, in __getitem__
    return self.locals[item][0]
KeyError: 'st'
$

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170501/63ea4834/attachment-0001.html>