[Webkit-unassigned] [Bug 171431] [GTK] Add GTK+ implementation of WebAutomationSession

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=171431

--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 308528
  --> https://bugs.webkit.org/attachment.cgi?id=308528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308528&action=review

This looks good to me, though I cannot really assess bugs in usage of GTK platform specifics. You probably want a GTK reviewer too.

> Source/WebKit2/UIProcess/Automation/WebAutomationSession.h:231
> +    // GTK+ doesn't keep track of the active modifiers when using synthesizez events.

Typo: synthesized.

> Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:36
> +static inline unsigned modifiersToEventState(WebEvent::Modifiers modifiers)

These probably don't need to be 'inline'.

> Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:51
> +static inline unsigned mouseButtonToGdkButton(Inspector::Protocol::Automation::MouseButton button)

Ditto.

> Source/WebKit2/UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:86
> +static void doMotionEvent(GtkWidget* widget, const WebCore::IntPoint& location, unsigned state)

Just FYI, on Mac we don't interpolate intermediate mouse positions. We might do so once the Actions API is implemented since it naturally specifies a duration for transitions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170501/6078f1aa/attachment.html>