[Webkit-unassigned] [Bug 170316] WebAssembly: Ref count Signature and SignatureInformation should not care about VM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170316

Keith Miller <keith_miller at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306001|review?                     |review+
              Flags|                            |

--- Comment #10 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 306001
  --> https://bugs.webkit.org/attachment.cgi?id=306001
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=306001&action=review

r=me

> Source/JavaScriptCore/wasm/WasmSignature.cpp:72
> +    void* memory = Signature::operator new (allocatedSize(argumentCount));
> +    Signature* result = new (memory) Signature(argumentCount);

Why not use the NotNull flag?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170331/8b866f93/attachment.html>