[Webkit-unassigned] [Bug 170222] New: [jsc][dfg] Don't use DFG intrinsic for HasOwnProperty on MIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170222

            Bug ID: 170222
           Summary: [jsc][dfg] Don't use DFG intrinsic for HasOwnProperty
                    on MIPS
           Product: WebKit
           Version: Other
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: guijemont at igalia.com

We don't have enough registers for the generic version of the intrinsic, and simply using the X86 version on MIPS makes some stress tests crash.

  stress/has-own-property-name-cache-string-keys.js
  DFG ASSERTION FAILED: Edge verification error: @80->Check:String:@57 was expected to have type String but has type Top (14898167807)
  ../Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h(134) : void JSC::DFG::AbstractInterpreter<AbstractStateType>::verifyEdge(JSC::DFG::Node*, JSC::DFG
  ::Edge) [with AbstractStateType = JSC::DFG::InPlaceAbstractState]

and

  JSTests/stress/has-own-property-name-cache-symbol-keys.js
  DFG ASSERTION FAILED: Edge verification error: @80->Check:Symbol:@57 was expected to have type Symbol but has type Top (14898167807)
  ../Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h(134) : void JSC::DFG::AbstractInterpreter<AbstractStateType>::verifyEdge(JSC::DFG::Node*, JSC::DFG
  ::Edge) [with AbstractStateType = JSC::DFG::InPlaceAbstractState]


Ideally we should see if we can fix the X86 version or make a MIPS variant of it (I started playing with that but don't have it working yet), in the mean time, I think we should deactivate the intrinsic on MIPS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170329/8f8e90b5/attachment.html>