[Webkit-unassigned] [Bug 166695] [ESNext] Async iteration - Implement Async Generator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 27 12:40:02 PDT 2017


--- Comment #48 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 305496
  --> https://bugs.webkit.org/attachment.cgi?id=305496

View in context: https://bugs.webkit.org/attachment.cgi?id=305496&action=review

Looks good overall, just a couple comments.

Obviously, it would be great if Sam or one of the other JSC core folks could give their opinion on it, since I can't sign off on WebKit patches.

> Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:57
> +        @asyncGeneratorResumeNext(generator);

Parameterizing the recursion seems weird to me still. I've suggested some changes that make this unnecessary

> Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:80
> +        @asyncGeneratorResumeNext(generator);

ditto here

> Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:114
> +                                        const restartResumeNext = true;

There's no need to recurse here, really. You can just call AsyncGeneratorResumeNext at the end of the method instead (and, you could even PTC to it in that case, since there's no generator on the stack at this point)

> Source/JavaScriptCore/builtins/AsyncGeneratorPrototype.js:125
> +                                        const restartResumeNext = true;

ditto here

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170327/5f24a7ef/attachment-0001.html>

More information about the webkit-unassigned mailing list