[Webkit-unassigned] [Bug 168425] REGRESSION(r205841): [GTK] Test fast/images/animated-png.html is failing since r205841

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 27 08:29:40 PDT 2017


--- Comment #2 from Miguel Gomez <magomez at igalia.com> ---
> I've debugged this and what happens is that BitmapImage::shouldAnimate() is
> false because PNGImageDecoder::repetitionCount() is returning 0, which means
> that it's not an animation.
> The curious thing is that PNGImageDecoder reads 1 as the repetition value
> from the file, but it returns that value minus 1, making it 0. It has been
> that way since that code was added but I don't know why. Just removing that
> minus 1 and returning the gotten repetition value makes the animations work
> again.

Ah, in the APNG format, 0 for the repetition count means repeat indefinitely, but in the webkit code we use -1 for that. That's probably the explanation for the minus 1... but that's not valid as the code is now.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170327/3e66e48a/attachment.html>

More information about the webkit-unassigned mailing list