[Webkit-unassigned] [Bug 168425] REGRESSION(r205841): [GTK] Test fast/images/animated-png.html is failing since r205841

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 27 08:06:05 PDT 2017


Miguel Gomez <magomez at igalia.com> changed:

           What    |Removed                     |Added
                 CC|                            |magomez at igalia.com

--- Comment #1 from Miguel Gomez <magomez at igalia.com> ---
The test is running several animations and comparing the final frame of each animation to a reference one. This is failing because the png animations are not running at all, and what it's comparing is the first frame of the animation instead of the last one.

I've debugged this and what happens is that BitmapImage::shouldAnimate() is false because PNGImageDecoder::repetitionCount() is returning 0, which means that it's not an animation.
The curious thing is that PNGImageDecoder reads 1 as the repetition value from the file, but it returns that value minus 1, making it 0. It has been that way since that code was added but I don't know why. Just removing that minus 1 and returning the gotten repetition value makes the animations work again.

This fixes the result in 9 of the 10 images used in the test. The failing one has some small differences in some pixels, probably due to small variations in the decoding result.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170327/645159f9/attachment.html>

More information about the webkit-unassigned mailing list