[Webkit-unassigned] [Bug 170027] New: Consider changing MachineThreads::m_registeredThreads to be a linked list of WTFThreadData.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=170027

            Bug ID: 170027
           Summary: Consider changing MachineThreads::m_registeredThreads
                    to be a linked list of WTFThreadData.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

Currently, MachineThreads instantiates MachineThreads::Thread (which is just a linked list node) that points to MachineThreads::ThreadData (a thread specific record that basically copies the content of WTFThreadData i.e. the stack bounds, and adds a few other things).  In order to instantiate the MachineThreads::ThreadData, the code needs to consult (and thereby create) the WTFThreadData instance anyway.

If we can lower PlatformThread to the WTF layer (and unify it with whatever representation of a thread id we have there e.g. that which is returned by currentThread()), then we can add that to WTFThreadData.  I think it is also fine to add the other platform specific MachineThreads::ThreadData fields to WTFThreadData as well.

Note: a side detail, we used to copy the stack bounds base and end.  Instead, we can change MachineStackMarker.cpp to use StackBounds::contains() instead to check the stack bounds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170323/bef8a87e/attachment.html>