[Webkit-unassigned] [Bug 169709] Follow-up on comments for bug 169664

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169709

--- Comment #1 from Jon Lee <jonlee at apple.com> ---
(In reply to comment #0)
> From Youenn:
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:865
> > +    Vector<RTCIceTransportState> transportStates;
> 
> I know this is untouched code.
> Would you be able to use reserveInitialCapacity/uncheckedAppend
> 
> > Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp:870
> > +    m_peerConnection.updateIceConnectionState(static_cast<RTCIceConnectionState>(derivedState));
> 
> This looks bad, deriveAggregatedIceConnectionState should really be changed
> to return RTCIceConnectionState.

I have a patch for this, but should MediaEndpointPeerConnection be part of the xcodeproj at all?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170319/f924c18f/attachment.html>