[Webkit-unassigned] [Bug 153911] Web Inspector: REGRESSION: Elements Tab > Node Details Sidebar > Properties Section is spammed with TypeErrors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 15 10:53:15 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=153911

--- Comment #14 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 304455
  --> https://bugs.webkit.org/attachment.cgi?id=304455
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=304455&action=review

>> Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js:240
>> +    setPrototypeNameOverride(override)
> 
> Any reason not to use a setter?  Or do you want this to be more of a "mode change" in the way it's read (meaning it's not just a value but instead it's a fully fledged function and will do stuff) ?

Yeah, I want this to feel like a mode change, not some property that you can set at any time. Something you set initially and never touch again. And its so rare (just this one place) that its not a constructor param.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170315/2c8b7266/attachment-0001.html>


More information about the webkit-unassigned mailing list