[Webkit-unassigned] [Bug 169632] New: In WK1, deleting localstorage for a single origin can leak data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169632

            Bug ID: 169632
           Summary: In WK1, deleting localstorage for a single origin can
                    leak data
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Local Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit API
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ansh_shukla at apple.com

This is an issue with the -[WebStorageManager deleteOrigin:] API. Calling this method tries to delete the localstorage database file on disk in StorageTracker::syncDeleteOrigin. However, we currently only delete the database file and none of its associated temporary SQLite files. One of the temporary files we fail to delete is the write-ahead log which contains local storage data that hasn’t been checkpointed. The net result is that if we wipe the local storage database and then recreate it, SQLite retains any “deleted” data that was kept around in the WAL.

By default the WAL only checkpoints (i.e. moves data into the database) every 1000 pages. This is a significant amount of data we could potentially leak.

We should fix this by also deleting the temporary files. We already have a method to do so in SQLiteFileSystem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170314/ef437970/attachment.html>