[Webkit-unassigned] [Bug 169597] New: Wrong condition in offlineasm/risc.rb

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169597

            Bug ID: 169597
           Summary: Wrong condition in offlineasm/risc.rb
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tpopela at redhat.com

Found by Coverity scan:

webkitgtk-2.14.5/Source/JavaScriptCore/offlineasm/risc.rb:378: unused_expr: Discarding the result of operator "==" in "node.operands().size() == 2". What was this code intended to accomplish?
webkitgtk-2.14.5/Source/JavaScriptCore/offlineasm/risc.rb:378: remediation: Did you intend to make an assertion or assignment?
#  376|                           (not validImmediates.include? node.operands[0].value) and
#  377|                           validImmediates.include? -node.operands[0].value
#  378|->                         node.operands.size == 2
#  379|                       if node.opcode =~ /add/
#  380|                           newOpcode = "sub" + $~.post_match

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170314/c1a540d9/attachment-0001.html>