[Webkit-unassigned] [Bug 169182] Currency digits calculation in Intl.NumberFormat should call out to ICU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169182

--- Comment #14 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 304259
  --> https://bugs.webkit.org/attachment.cgi?id=304259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=304259&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Revert patch to call out to ICU for CurrencyDigits

Nit: please say which revision you're rolling out.

> Source/JavaScriptCore/ChangeLog:5
> +        The previous patch was currently technical invalid because ECMA 402

Style nit: we usually put this after the "reviewed by" line. 
Also, "currently techinical invalid" => "is technically invalid"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170313/c86c7165/attachment.html>