[Webkit-unassigned] [Bug 152418] Web Inspector: Make WebInspector.ConsoleMessageView faster

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=152418

--- Comment #6 from Nikita Vasilyev <nvasilyev at apple.com> ---
(In reply to comment #4)
> (In reply to comment #1)
> > (In reply to comment #0)
> > > Created attachment 267609 [details]
> > > [Image] Stacktrace in Timelines
> > 
> > This timeline recording shows that _appendLocationLink takes 23.13ms
> > out of 23.43ms of ConsoleMessageView execution time. That's 98.7%!
> > 98.7% of ConsoleMessageView execution time spent on adding the source link.
> > 
> > I don't understand what happens in addEventListener selected on the image.
> > Timelines doesn't tell me why *adding* an event listener takes so long.
> 
> Our addEventListener is O(n).
> 
>         for (var i = 0; i < listeners.length; ++i) {
>             if (listeners[i].listener === listener &&
> listeners[i].thisObject === thisObject)
>                 return;
>         }
> 
> Put it in a loop and it's O(n^2)!

This was addressed over a year ago.

However, issues mentioned in comments 1–3 weren't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170310/24747048/attachment.html>