[Webkit-unassigned] [Bug 169471] New: webkit-patch upload does not detect file renames when using git

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 10 09:01:50 PST 2017


            Bug ID: 169471
           Summary: webkit-patch upload does not detect file renames when
                    using git
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: svijayaraghavan at apple.com
                CC: lforschler at apple.com

Running git diff locally shows that a file has been renamed, but the patch actually uploaded by `webkit-patch upload` uses git diff with --no-renames to generate the patch (See create_patch() in webkitpy/common/checkout/scm/git.py). As a result, the uploaded patch shows a deleted file and a new file, thereby losing history.

That --no-renames flag was added in 2011 as part of https://bugs.webkit.org/show_bug.cgi?id=48075. Filing this bug now since I'm not sure if those issues still exist, or if they have since become feasible to fix.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170310/fb3d75bc/attachment-0001.html>

More information about the webkit-unassigned mailing list