[Webkit-unassigned] [Bug 169345] Loading in-body stylesheets should not block rendering of elements before them

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169345

--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 303812
  --> https://bugs.webkit.org/attachment.cgi?id=303812
wip

View in context: https://bugs.webkit.org/attachment.cgi?id=303812&action=review

> Source/WebCore/dom/Document.cpp:1251
> +    fprintf(stderr, "Document::setVisualUpdatesAllowed %d\n", visualUpdatesAllowed);

You should add LOG(Style, ...) for logging like this that you find useful.

> Source/WebCore/dom/Document.cpp:1824
> +        if (m_renderView->needsLayout())
> +            frameView.scheduleRelayout();

How does needsLayout() become true without a layout already having been scheduled? This seems odd.

> Source/WebCore/rendering/RenderBlock.cpp:1536
> +        fprintf(stderr, "RenderBlock::paint isNotFinal\n");

LOG(Style, ...)?

> Source/WebCore/rendering/RenderLayer.cpp:3945
> +        fprintf(stderr, "shouldSuppressPaintingLayer\n");

Log(Style, ...)?

> Source/WebCore/style/StyleTreeResolver.cpp:171
> +        fprintf(stderr, "m_didSeePendingStylesheet not styling\n");

LOG

> Source/WebCore/style/StyleTreeResolver.cpp:184
> +        fprintf(stderr, "m_didSeePendingStylesheet marking non-final\n");

LOG

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170308/79225183/attachment.html>