[Webkit-unassigned] [Bug 169262] New: [WebCrypto] Replace const std::unique_ptr<CryptoAlgorithmParameters>&& with const CryptoAlgorithmParameters& for CryptoAlgorithm::importKey

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169262

            Bug ID: 169262
           Summary: [WebCrypto] Replace const
                    std::unique_ptr<CryptoAlgorithmParameters>&& with
                    const CryptoAlgorithmParameters& for
                    CryptoAlgorithm::importKey
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jiewen_tan at apple.com

Current method CryptoAlgorithm::importKey is defined as follow:
void importKey(SubtleCrypto::KeyFormat, KeyData&&, const std::unique_ptr<CryptoAlgorithmParameters>&&, bool extractable, CryptoKeyUsageBitmap, KeyCallback&&, ExceptionCallback&&);

A const rvalue reference makes no sense here. Therefore, I propose it should be rewritten as:
void importKey(SubtleCrypto::KeyFormat, KeyData&&, const CryptoAlgorithmParameters&, bool extractable, CryptoKeyUsageBitmap, KeyCallback&&, ExceptionCallback&&);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170307/05179602/attachment.html>