[Webkit-unassigned] [Bug 162124] op_get_by_id_with_this should use inline caching

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=162124

--- Comment #92 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 302467
  --> https://bugs.webkit.org/attachment.cgi?id=302467
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=302467&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:4346
> +            jsValueResult(resultTagGPR, resultPayloadGPR, node, UseChildrenCalledExplicitly);

The assertion is because you're passing UseChildfenCalledExplicitly here. Because you're not calling use(), you should not pass this value. I think the default parameter will not pass this value.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:4366
> +            jsValueResult(resultTagGPR, resultPayloadGPR, node, UseChildrenCalledExplicitly);

Ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170305/bef5490d/attachment.html>