[Webkit-unassigned] [Bug 165225] UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #38 from Brad Wright <bwright2 at apple.com> ---
Comment on attachment 303134
  --> https://bugs.webkit.org/attachment.cgi?id=303134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303134&action=review

>> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392
>> +    UIViewController *presentedViewController = [UIViewController _viewControllerForFullScreenPresentationFromView:_view];
> 
> So if I understand correctly, [UIViewController _viewControllerForFullScreenPresentationFromView:_view] will fetch the _presentationPopover, if it exists, as well? If that is really the case, then this is OK, but we should at least tear down _presentationPopover properly (i.e. nil out _presentationPopover and set its delegate to nil).

We don't actually need to call [_presentationPopover dismissPopoverAnimated:animated]; because this will take care of it:
[[UIViewController _viewControllerForFullScreenPresentationFromView:_view] dismissViewControllerAnimated:NO completion:nil];
I'm going to add this:
// Clean up any pointers
    [_presentationPopover setDelegate:nil];
    _presentationPopover = nil;
    _presentationViewController = nil;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170303/654b2461/attachment.html>