[Webkit-unassigned] [Bug 165225] UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #37 from Tim Horton <thorton at apple.com> ---
(In reply to comment #36)
> (In reply to comment #35)
> > Comment on attachment 303134 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=303134&action=review
> > 
> > >> Source/WebKit2/ChangeLog:3
> > >> +        Don't dismiss the viewcontroller if the viewcontroller dismisses itself.  - (void)dismiss now removes any presented view controller directly.
> > > 
> > > Please fix this title as well.
> > 
> > Is this okay?  
> > 
> > Clear out the view controller we just presented. Don't dismiss the
> > UIDocumentMenuViewController as it is self dismissing.
> 
> Oh, sorry -- I should've clarified; typically, the title of the ChangeLog
> entry is the title of the bug itself (so in this case, it would be
> 'UIViewController with WKWebView presented modally causes the presented
> UIViewController to be dismissed.')

Take a look at https://trac.webkit.org/changeset/213304 for a good example of change log format.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170303/ccbfc15e/attachment.html>