[Webkit-unassigned] [Bug 165225] UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #32 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 303134
  --> https://bugs.webkit.org/attachment.cgi?id=303134
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303134&action=review

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:391
> +    // dismiss any viewController that is being presented. This is works for all types of viewcontrollers , popovers, etc.

Please capitalize "dismiss"

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392
> +    UIViewController *presentedViewController = [UIViewController _viewControllerForFullScreenPresentationFromView:_view];

So if I understand correctly, [UIViewController _viewControllerForFullScreenPresentationFromView:_view] will fetch the _presentationPopover, if it exists, as well? If that is really the case, then this is OK, but we should at least tear down _presentationPopover properly (i.e. nil out _presentationPopover and set its delegate to nil).

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:506
> +    // Clear out any previous view controller reference, to prevent calling dismiss on a view controller that

Per Darin's advice a few comments above, this should really say "Clear out the view controller we just presented" rather than refer to the view controller we're clearing out as the "previous" one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170303/8415106b/attachment.html>