[Webkit-unassigned] [Bug 165225] UIViewController with WkWebView presented modally causes the presented UIViewController to be dismissed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165225

--- Comment #22 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 303114
  --> https://bugs.webkit.org/attachment.cgi?id=303114
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=303114&action=review

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:-389
> -    [self _dismissDisplayAnimated:NO];

_dismissDisplayAnimated: handles dismissing the _presentationPopover. If we aren't going to go through _dismissDisplayAnimated: here, we need to still dismissPopoverAnimated: on the _presentationPopover.

> Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392
> +    UIViewController *presentedVC = [UIViewController _viewControllerForFullScreenPresentationFromView:_view];

WebKit style guidelines (https://webkit.org/code-style-guidelines/) recommend using full variable names rather than abbreviations, so presentedVC should be presentedViewController.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/57f35cc8/attachment.html>