[Webkit-unassigned] [Bug 169024] REGRESSION(r213062): [SOUP] UTF-8 filename in Content-Disposition header incorrectly handled since r213062

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 1 09:12:18 PST 2017


https://bugs.webkit.org/show_bug.cgi?id=169024

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |youennf at gmail.com

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 303055 [details]
> Patch
> 
> I don't understand it. You convert the header from UTF-8 to the internal
> encoding (UTF-16)... but only if it's ASCII...?

In r176930 ResourseResponse was changes to not apply any encoding conversion from message headers when adding them to the header map. So, we create the String with String constructor no String__fromaUTF8() so that we don't actually make any charset conversion. The header could be either utf8 or latin1, so we try to convert to utf8, only when it's not, falling back to latin1 if the conversion fails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/e407c6ae/attachment.html>


More information about the webkit-unassigned mailing list