[Webkit-unassigned] [Bug 169031] New: [Cairo] Incorrectly determining height in GraphicsContext::roundToDevicePixels()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=169031

            Bug ID: 169031
           Summary: [Cairo] Incorrectly determining height in
                    GraphicsContext::roundToDevicePixels()
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: tpopela at redhat.com
                CC: bugs-noreply at webkitgtk.org, cgarcia at igalia.com

Found by Coverity scan:

1. webkitgtk-2.14.5/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:748: original: "width < 0." looks like the original copy.
2. webkitgtk-2.14.5/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:754: copy_paste_error: "width" in "width < 0." looks like a copy-paste error.
3. webkitgtk-2.14.5/Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:754: remediation: Should it say "height" instead?
#   752|       else
#   753|           width = round(width);
#   754|->     if (height > -1 && width < 0)
#   755|           height = -1;
#   756|       else if (height > 0 && height < 1)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170301/50ecffa7/attachment.html>