[Webkit-unassigned] [Bug 174056] WIP - RunBenchmark WebDriver testing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 30 17:58:19 PDT 2017


--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 314327
  --> https://bugs.webkit.org/attachment.cgi?id=314327

View in context: https://bugs.webkit.org/attachment.cgi?id=314327&action=review

> Tools/ChangeLog:7
> +

A lot of files are duplicated. We should try to figure out a way to reuse the code from run-benchmark.

> Tools/Scripts/webkitpy/webdriver_benchmark_runner/README.md:1
> +# Benchmark Runner 

Looks like this file need to be updated.

> Tools/Scripts/webkitpy/webdriver_benchmark_runner/benchmark_runner.py:19
> +'''from selenium import webdriver
> +from selenium.webdriver.chrome.options import Options'''

We should remove commented code.

> Tools/Scripts/webkitpy/webdriver_benchmark_runner/browser_driver/linux_browser_driver.py:32
> +from selenium import webdriver

Is this used?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170701/5121ff43/attachment.html>

More information about the webkit-unassigned mailing list