[Webkit-unassigned] [Bug 173970] New: enum constant CSSValueOblique in boolean context in CSSFontStyleValue.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173970

            Bug ID: 173970
           Summary: enum constant CSSValueOblique in boolean context in
                    CSSFontStyleValue.h
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sandervv+webkit at gmail.com

I saw a compiler warning that looks like a typo and can cause a problem.

/home/smvv/work/jhbuild/checkout/webkitgtk-2.17.4/Source/WebCore/css/CSSFontStyleValue.h: In member function ‘bool WebCore::CSSFontStyleValue::isItalic() const’:
/home/smvv/work/jhbuild/checkout/webkitgtk-2.17.4/Source/WebCore/css/CSSFontStyleValue.h:53:49: warning: enum constant in boolean context [-Wint-in-bool-context]
             return valueID == CSSValueItalic || CSSValueOblique;
                                                 ^~~~~~~~~~~~~~~

A fix would be:

             return valueID == CSSValueItalic || valueID == CSSValueOblique;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170629/b74add8d/attachment.html>