[Webkit-unassigned] [Bug 173968] REGRESSION(r218896): ASSERT in WebPageProxy::dataCallback

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 29 08:21:10 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=173968

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 314131 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=314131&action=review
> 
> > Source/WebCore/loader/DocumentLoader.cpp:1717
> > +    RELEASE_ASSERT(callbackIdentifier);
> > +    RELEASE_ASSERT(m_frame);
> 
> IMO there's no particular reason for these to be release asserts rather than
> normal asserts.

No that I haven't added it, but moved and it was already a release assert. Then I added the frame one, and used release assert too for consistency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170629/6f7e85e3/attachment.html>


More information about the webkit-unassigned mailing list