[Webkit-unassigned] [Bug 173889] [Win] Build JSCOnly on Windows with clang-cl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173889

--- Comment #8 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 313956
  --> https://bugs.webkit.org/attachment.cgi?id=313956
Patch to build jsc-only with clang-cl toolset - combined clang-cl/gcc/clang4 option

View in context: https://bugs.webkit.org/attachment.cgi?id=313956&action=review

>>>>> Source/cmake/OptionsCommon.cmake:57
>>>>> +    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-strict-aliasing -fno-rtti")
>>>> 
>>>> Don't duplicate these lines
>>> 
>>> These were duplicated from above. I'm guessing because those options are never going to change.
>> 
>> 
> 
> I'm sorry, I'm not sure what you mean here. Is it because we're doing -fno-strict-aliasing in both branches? We aren't passing -fno-exceptions or -fno-rtti in the clang-cl case, but it'd be easy to separate the common one out if that seems better.

Yes, it would be better

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170628/f0273bf8/attachment.html>