[Webkit-unassigned] [Bug 173874] DocumentLoader should always notify the client if there are pending icon loads when the load is stopped

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173874

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Brady Eidson from comment #6)
> Created attachment 314037 [details]
> Proposed patch while working on test
> 
> This is the patch I'm working with as I develop a test.
> 
> It's very close to yours, clearly. Two changes, one stylistic and one
> functional:
> 
> Stylistic - Factor out the notifyFinishedLoadingIcon method for the 3 places
> that use it
> Functional - In didGetLoadDecisionForIcon it's important to *always* do the
> take. We can't early return on !decision or !m_frame without first doing the
> take.

Good point, sounds good to me, thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170628/47a74cab/attachment.html>