[Webkit-unassigned] [Bug 173874] DocumentLoader should always notify the client if there are pending icon loads when the load is stopped

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 28 10:32:11 PDT 2017


--- Comment #6 from Brady Eidson <beidson at apple.com> ---
Created attachment 314037

  --> https://bugs.webkit.org/attachment.cgi?id=314037&action=review

Proposed patch while working on test

This is the patch I'm working with as I develop a test.

It's very close to yours, clearly. Two changes, one stylistic and one functional:

Stylistic - Factor out the notifyFinishedLoadingIcon method for the 3 places that use it
Functional - In didGetLoadDecisionForIcon it's important to *always* do the take. We can't early return on !decision or !m_frame without first doing the take.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170628/f38f0ae6/attachment.html>

More information about the webkit-unassigned mailing list