[Webkit-unassigned] [Bug 173862] [GTK] Layout Test webrtc/video.html issues "stack smashing detected"
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 26 22:31:56 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=173862
--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Fujii Hironori from comment #1)
> Created attachment 313896 [details]
> WIP patch
>
> It seems that g_object_get needs to be passed an int pointer instread of a
> bool pointer.
Yes, this has caused problems in the past.
> WIP patch solved the stack smashing.
>
> But, there are other similar codes using g_object_get and bool pointers.
>
> > bool MediaPlayerPrivateGStreamerBase::muted() const
> > {
> > if (!m_volumeElement)
> > return false;
> >
> > bool muted;
> > g_object_get(m_volumeElement.get(), "mute", &muted, nullptr);
> > return muted;
> > }
>
> Does anyone have any thought?
We should fix all of them, by using gboolean instead of bool.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170627/80c816f5/attachment.html>
More information about the webkit-unassigned
mailing list