[Webkit-unassigned] [Bug 173804] REGRESSION (AsyncImageDecoding): A tab with the WWDC keynote paused is killed for using excessive power (Image thrashing)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173804

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313874|review?                     |review+
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 313874
  --> https://bugs.webkit.org/attachment.cgi?id=313874
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=313874&action=review

> Source/WebCore/platform/graphics/BitmapImage.cpp:229
> +                imageObserver()->didDraw(*this);

It's confusing, and not very future-proof, to call something called 'didDraw' when we didn't actually draw.

> LayoutTests/fast/images/low-memory-decode.html:15
> +    }, 100);

This will always take 100ms. Consider using shouldBecomeTrue().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170626/6f756f97/attachment.html>